Fix test_train to not rely on 'Sanity Checking' stdout in multi-GPU runs
#10478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
puririshi98
requested changes
Oct 3, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10478 +/- ##
==========================================
- Coverage 86.11% 85.09% -1.02%
==========================================
Files 496 510 +14
Lines 33655 35962 +2307
==========================================
+ Hits 28981 30601 +1620
- Misses 4674 5361 +687 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
for more information, see https://pre-commit.ci
…ometric into sanity_check
puririshi98
approved these changes
Oct 3, 2025
akihironitta
reviewed
Oct 3, 2025
akihironitta
approved these changes
Oct 3, 2025
puririshi98
approved these changes
Oct 6, 2025
akihironitta
approved these changes
Oct 10, 2025
auto-merge was automatically disabled
October 10, 2025 17:35
Invalid email address
ssubhanjali
pushed a commit
to ssubhanjali/pytorch_geometric
that referenced
this pull request
Oct 28, 2025
… runs (pyg-team#10478) The test `test_train` previously asserted on the presence of the "Sanity Checking" message in stdout. This was brittle because in multi-GPU/DistributedDataParallel runs, **only rank 0 prints this message**, so tests running on other ranks failed. This PR updates the test to: - Remove the fragile stdout assertion. - Assert trainer state (`!trainer.sanity_checking`, `current_epoch >= 0`). - Use LoggerCallback to verify that both training and validation ran. This makes the test deterministic and robust across single-GPU, multi-GPU, and CI environments. [PassingLog.TXT](https://github.com/user-attachments/files/22671419/PassingLog.TXT) --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Akihiro Nitta <[email protected]> Co-authored-by: Rishi Puri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test
test_trainpreviously asserted on the presence of the "Sanity Checking" message in stdout. This was brittle because in multi-GPU/DistributedDataParallel runs, only rank 0 prints this message, so tests running on other ranks failed.This PR updates the test to:
!trainer.sanity_checking,current_epoch >= 0).This makes the test deterministic and robust across single-GPU, multi-GPU, and CI environments.
PassingLog.TXT